-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify Contributing for Typescript 2.0 #11210
Comments
I have the same doubt about the first question. I found most of the contributors send PR to Suppose developers install the definitions from |
Hi, I'm writing "MY" opinions. Now, 1.8.10 is latest stable release version of TypeScript. I suggestion we should send PR to I just added @types label to Issue and PR. latest I am not confident. but... check see If you can read japanese. I'm writing technical article for TypeScript 2.0. |
@vvakame @RyanCavanaugh When does For example, I want to merge the latest mongoose definitions on into the one on The version on master was update a couple weeks ago. There's a commit on |
FYI you might find some value in reviewing this issue and the responses therein #10711 . |
This should now be answered by the new README: #12070 |
Hi,
I ran into some points of confusion about contributing to DefinitelyTyped that don't seem to be answered in the contribution guide. I wanted to flag those here so that the answers can be documented in the future. (Answers to these questions would be appreciated, but I understand if StackOverflow is the better venue for that.)
master
or thetypes-2.0
branch? Both?index.d.t.s
rather than{libname}.d.ts
. Declarations on that branch also seem to be written differently. E.g., the express declarations are wrapped in adeclare module "express" {}
block on master, but not on types-2.0. Should contributors worry about/account for these differences? Or is there some way that the files on types-2.0 are being automatically pre-processed to account for these changes. (Preprocessing could easily change the name, and seems to be happening in other places; see below.)types-2.0
branch use a new<reference types="">
directive. I understand that this still needs to be documented further, but the documentation I could find seems to suggest that<reference types="">
should be used to pull in the types for a global, but an import could be used to pull in the types for a module... and yet the express declarations on types-2.0 uses bothimport
and<reference types="">
. Why? Since<reference types="">
is new to 2.0, I can't imagine it's for backwards compatibility...<reference path="">
to seems to have been updated<reference types="">
manually by @RyanCavanaugh's commit, but other files (e.g.)on the types-2.0 branch still seem to be using the<reference path="">
syntax... and yet, if I install it through NPM, I see the<reference types="">
syntax instead. Does that mean the types publisher is doing some kind of auto-rewriting, as I alluded to above? And, if so, what does this mean for contributors too?The text was updated successfully, but these errors were encountered: