Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[three] Cannot find 'VRDisplay' #29515

Closed
Chiff opened this issue Oct 7, 2018 · 4 comments
Closed

[three] Cannot find 'VRDisplay' #29515

Chiff opened this issue Oct 7, 2018 · 4 comments

Comments

@Chiff
Copy link

Chiff commented Oct 7, 2018

After using @types/three i get this error:

ERROR in node_modules/@types/three/three-core.d.ts(7799,18): error TS2304: Cannot find name 'VRDisplay'.
node_modules/@types/three/three-core.d.ts(7800,23): error TS2304: Cannot find name 'VRDisplay'.
node_modules/@types/three/three-vrcontrols.d.ts(15,27): error TS2304: Cannot find name 'VRDisplay'.
node_modules/@types/three/three-vreffect.d.ts(20,27): error TS2304: Cannot find name 'VRDisplay'.

Reproduction steps:

  • ng new app
  • yarn add @types/three
  • Adding reference to app.component.ts: /// <reference path="../../node_modules/@types/three/index.d.ts"/>
  • ng serve

Right now i'm editing lines below to type any

getDevice(): VRDisplay | null;

setDevice(device: VRDisplay | null): void;

setVRDisplay(display: VRDisplay): void;

setVRDisplay(display: VRDisplay): void;

Is this issue on my side or can I create pull request to change type from VRDisplay to any?

Repo: https://github.com/Chiff/Vrdisplay-issue-types-three

@Chiff Chiff changed the title Cannot find 'VRDisplay' Cannot find 'VRDisplay' at 'three' Oct 7, 2018
@Chiff Chiff changed the title Cannot find 'VRDisplay' at 'three' [three] Cannot find 'VRDisplay' Oct 7, 2018
@ryan0122
Copy link

I'm having the same issues. Please address.

@vkarenko
Copy link

Hi all!
I'm just updated version of "Typescript" to v.2.8.1 in my project and it's compiling without any errors now.

@Chiff
Copy link
Author

Chiff commented Oct 18, 2018

Hi all!
I'm just updated version of "Typescript" to v.2.8.1 in my project and it's compiling without any errors now.

I did test typescript@2.8.1 and it did not make any error.

However it is producing following warning:

@angular/compiler-cli@6.1.9 requires typescript@'>=2.7.0 <2.8.0' but 2.8.1 was found instead.
Using this version can result in undefined behaviour and difficult to debug problems.

Please run the following command to install a compatible version of TypeScript.

    npm install typescript@'>=2.7.0 <2.8.0'

To disable this warning run "ng config cli.warnings.typescriptMismatch false".

Also I should've mentioned I'm running project on angular@6.0.8 and after little search I found this issue angular/angular#25141 (comment). I will test it later.

@Chiff
Copy link
Author

Chiff commented Oct 18, 2018

Also look at #28692 (comment) (I will test it later)

@Chiff Chiff closed this as completed Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants