Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for [jasmine] 4.3.0 #61819

Open
koswedo opened this issue Aug 19, 2022 Discussed in #61476 · 5 comments
Open

support for [jasmine] 4.3.0 #61819

koswedo opened this issue Aug 19, 2022 Discussed in #61476 · 5 comments

Comments

@koswedo
Copy link

koswedo commented Aug 19, 2022

Discussed in #61476

Originally posted by koswedo July 27, 2022
spyOnGlobalErrorsAsync has been added in jasmine 4.3.0. Could it be added in here too?

Thank you

@abc516
Copy link

abc516 commented Oct 2, 2022

Hi @koswedo @grempe @nex3 , can I take on this issue please?

@grempe
Copy link
Contributor

grempe commented Oct 3, 2022

Can I ask you @abc516 why you are tagging me here? I am not affiliated with this issue.

@abc516
Copy link

abc516 commented Oct 3, 2022

Can I ask you @abc516 why you are tagging me here? I am not affiliated with this issue.

My bad, saw you were in the list of people in my tag autocomplete: I will tag @andrewbranch and @blakeembrey to gain visibility instead.

@Semigradsky
Copy link
Contributor

Semigradsky commented Oct 3, 2022

@koswedo spyOnGlobalErrorsAsync exists:

function spyOnGlobalErrorsAsync(fn?: (globalErrorSpy: Error) => Promise<void>): Promise<void>;

@rajsite
Copy link

rajsite commented Apr 10, 2023

The current type for spyOnGlobalErrorsAsync is incorrect. I think it should look something like:

function spyOnGlobalErrorsAsync(fn?: (globalErrorSpy: Spy<(err: Error) => void>) => Promise<void>): Promise<void>; 

i.e. globalErrorSpy is not an Error, it is a Spy on the global error handler function (a function that takes an error as the parameter).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants