Mistyped parameter in method update of Decipher class

[pbesret]

Hi there, I think the type defined here for the parameter inputEncoding with the signature method using a Buffer is wrong and should support Encoding too.

DefinitelyTyped/types/node/crypto.d.ts

Line 1189 in 7bd4a02

update(data: NodeJS.ArrayBufferView, inputEncoding: undefined, outputEncoding: Encoding): string;

Imo, inputEncoding property should have the same types as in this signature :

DefinitelyTyped/types/node/crypto.d.ts

Line 1190 in 7bd4a02

update(data: string, inputEncoding: Encoding | undefined, outputEncoding: Encoding): string;

Best regards,
Paul.

[pbesret]

Please can an moderator delete this....

[cweijan]

Here are the responses about this parameter: #59476

[pbesret]

Thanks for you answer. I don't understand, since it would be an unique signature even without the inputEncoding parameter with a Buffer, why can't we just remove this parameter if it is ignored ? Is it a retro-compatibility issue ? In which case we could mark it as deprecated.

[cweijan]

According to @SimonSchick's reply, the second parameter is ignored and the user should not pass it 😀.

[pbesret]

That doesn't answer the "why" can't we remove this parameter if it is ignored anyway ^^

[SimonSchick]

See https://nodejs.org/api/crypto.html#decipherupdatedata-inputencoding-outputencoding according to the docs inputEncoding still needs to be specified in order to be able to specify outputEncoding.

Please provide your use case or example of why this should not be the case.