Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/node/stream.d.ts pipeline signature missing mandatory flag for callback #69432

Closed
john30 opened this issue Apr 24, 2024 · 1 comment · Fixed by #69498
Closed

@types/node/stream.d.ts pipeline signature missing mandatory flag for callback #69432

john30 opened this issue Apr 24, 2024 · 1 comment · Fixed by #69498

Comments

@john30
Copy link

john30 commented Apr 24, 2024

according to the implementation in
https://github.com/nodejs/node/blob/91dc8c93a3d6ffa9de3bb7b7507e52df4a4aad90/lib/internal/streams/pipeline.js#L185
the signature has changed with commit nodejs/node@b920a10 to require the callback.
this should also be revealed here

callback?: PipelineCallback<B>,

and in the lines below

@codershiba
Copy link
Contributor

Created #69498 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants