Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backwater water surface computation? #140

Open
amoodie opened this issue Feb 15, 2021 · 0 comments
Open

backwater water surface computation? #140

amoodie opened this issue Feb 15, 2021 · 0 comments
Labels
discussion enhancement New feature or request

Comments

@amoodie
Copy link
Member

amoodie commented Feb 15, 2021

In _accumulate_free_surface_walks(), where the dH values are set within the delta I think it could be good to either add a comment, or open an issue to indicate that the if-else could be further split up to incorporate water surface assignment based on a backwater profile. This is something I've never played with, but was present in the Matlab implementation, @ericbarefoot have you?

The original Matlab implementation included commented out code that would enable a backwater computation of the water surface.

None of us have experimented with this, but it could be something to implement via a separate function or if-then statement and a flag in the configuration file.

@amoodie amoodie added discussion enhancement New feature or request labels Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant