Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "rich" output in console and logging #45

Open
amoodie opened this issue May 30, 2020 · 1 comment
Open

Implement "rich" output in console and logging #45

amoodie opened this issue May 30, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@amoodie
Copy link
Member

amoodie commented May 30, 2020

There is currently a "logger" implemented all over the code, which I guess spits out to a txt file. It would be a good two-for-one to implement the rich console logger (link here), to write to console and to file every time the logger is called in the current code. We should also log to file every time we raise a warning.

Currently, we sometimes print things to console, sometimes log things to file, sometimes warn things, and sometimes a combination of the three. We should make this consistent based on the verbose flag. relates to #40

@amoodie amoodie added the enhancement New feature or request label May 30, 2020
@ericbarefoot ericbarefoot added this to the Stable API milestone Jun 2, 2020
@amoodie
Copy link
Member Author

amoodie commented Jun 9, 2020

PR #54 took care of most of this (we have to keep up good practices about logging and printing and warnings though!!).

What's left is to implement the rich printing as suggested on slack. I think this should be pretty straightforward: https://rich.readthedocs.io/en/latest/logging.html

I'm going to rename the issue to reflect this remaining focus.

@amoodie amoodie added the good first issue Good for newcomers label Jun 9, 2020
@amoodie amoodie changed the title rich output, console logging, printing, warnings Implement "rich" output in console and logging Jun 9, 2020
@amoodie amoodie added this to To do in Version 2.0 Jun 24, 2020
@amoodie amoodie removed this from To do in Version 2.0 Mar 9, 2021
@amoodie amoodie removed this from the Stable API milestone Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants