Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expected type for BMI configuration #34

Merged
merged 1 commit into from
May 21, 2020

Conversation

elbeejay
Copy link
Member

Was getting the following warning when running the run_pyDeltaRCM_as_BMI.py script:

Input for model_output__opt_time_interval not of the right type. model_output__opt_time_interval needs to be of type <class 'float'>

So the super minor commit in this PR just addresses that by changing the expected type for time to be 'int' instead of 'float' to match the convention in the non-BMI method. I don't see anything in the CSDMS BMI naming convention that suggests the "time_interval" variable must be a 'float'.

Copy link
Collaborator

@ericbarefoot ericbarefoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I wonder if in the future, we could come up with a script that compares across the wrapper and the defaults to make sure that all parameters in the wrapper correspond to a real parameter in the model, and that the expected types match.

@elbeejay elbeejay merged commit 9e98300 into DeltaRCM:develop May 21, 2020
@elbeejay elbeejay mentioned this pull request May 21, 2020
@elbeejay elbeejay deleted the fix-time branch May 22, 2020 14:38
amoodie pushed a commit to amoodie/pyDeltaRCM that referenced this pull request Feb 25, 2021
Fix expected type for BMI configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants