-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor plotting behavior and grid/plot saving routines #59
Conversation
… in an earlier commit with previous PR
…, add flags to initialization for whether plotting or saving happens at all, then use those to enter if statements, only print to log once for figs and once for grids
…easier interaction with postprocessing, update tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I'm stoked that you tackled the plotting and files. That was a thorn bush I was dreading, and thus ignored. I'll go ahead and merge.
Refactor plotting according to #28.
defaults
I went with defaults all false:
sequential saving
I went with sequential saving by default (
eta_00000.png
,eta_00001.png
), and there is now a flag calledsave_figs_sequential
that takes a boolean. Setting this toFalse
giveseta_latest.png
which is repeatedly overwritten.refactoring
make_figure
andsave_figure
operations into functionseta
plotting