Improve "code quality" #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 9, 2020 15:56
ericbarefoot
approved these changes
Jun 13, 2020
Comment on lines
-45
to
+30
| iter = 0 | ||
| _iter = 0 |
There was a problem hiding this comment.
Oh yeah. This definitely needed to be changed, since iter is actually a reserved word right?
amoodie
added a commit
to amoodie/pyDeltaRCM
that referenced
this pull request
Feb 25, 2021
Improve "code quality"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve "code quality" baseline.
This PR just makes a bunch of fixes to the doctrings to bring the code quality up to a baseline that looks good enough to actually look over. Initially, there were a slew of failing marks because of the docstrings and imports, and these were so distracting that you couldn't barely even see the real issues in the code.
The code quality check I turned on should help us identify bad code practices in the code, and avoid code problems in the future. I'll open an issue to address the remaining issues identified by the code quality assessment.