Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unknown keywords to be read #630

Closed
tim-vd-aardweg opened this issue Apr 22, 2024 · 1 comment
Closed

Allow unknown keywords to be read #630

tim-vd-aardweg opened this issue Apr 22, 2024 · 1 comment
Assignees
Labels
priority: high type: feature Brand new functionality
Milestone

Comments

@tim-vd-aardweg
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In #571 we added a lot of new keywords. However, we only added keywords that are the manual. There are many more keywords being printed to the .dia file. In most cases, these are research keywords. We want a way to support the reading (and writing) of these keywords as well, without having to add them to the source code.

Describe the solution you'd like
We should probably set Extra.Allow to support this. We have to look into the best place to add this and what the consequences of this change are.

@tim-vd-aardweg
Copy link
Contributor Author

Discussed this issue with @arthurvd @rhutten @veenstrajelmer @MRVermeulenDeltares . We will not be supporting the reading and writing of unknown keywords after all. Mainly because there should be no unknown keywords at all. We will aim to add all currently 'unknown' keywords to HYDROLIB-core. Furthermore, we will make a tutorial for how the users can add keywords to models themselves. See #637.

I will therefore be closing this issue.

HYDROLIB-core automation moved this from To do to Done May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high type: feature Brand new functionality
Projects
HYDROLIB-core
  
Done
Development

No branches or pull requests

1 participant