Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug when lakes is true #258

Closed
laurenebouaziz opened this issue May 9, 2023 · 0 comments · Fixed by #259
Closed

bug when lakes is true #258

laurenebouaziz opened this issue May 9, 2023 · 0 comments · Fixed by #259
Assignees
Labels
bug Something isn't working

Comments

@laurenebouaziz
Copy link
Contributor

when running with the dev install on the master branch, I get the following error for a model where lakes=true:

┌ Error: Wflow simulation failed
│   exception =
│    UndefVarError: initialize_natural_lake not defined

If I look at the code, I indeed see in sbm_model.jl:
initialize_natural_lake(config, nc, inds_riv, nriv, pits, tosecond(Δt))
https://github.com/Deltares/Wflow.jl/blob/3bdad55970955e18dcdb8820aa4edce5c9a98668/src/sbm_model.jl#LL92C13-L92C13

however in reservoir_lakes.jl, the instance is called:
function initialize_lake(config, nc, inds_riv, nriv, pits, Δt)
it was recently renamed without the "natural"

function initialize_lake(config, nc, inds_riv, nriv, pits, Δt)

I think this might be related to the recent changes in the lake module but now it seems not to be consistent anymore, or am I overlooking something?

@verseve verseve self-assigned this May 9, 2023
@verseve verseve added the bug Something isn't working label May 9, 2023
@verseve verseve linked a pull request May 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants