Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better reservoir workflow and new data #20

Closed
hboisgon opened this issue May 12, 2021 · 1 comment
Closed

Better reservoir workflow and new data #20

hboisgon opened this issue May 12, 2021 · 1 comment
Labels
enhancement New feature or request priority This issue should be fixed with priority

Comments

@hboisgon
Copy link
Contributor

Add GRanD v1.3
Review reservoir and lakes methods

Preprocess lake/reservoir database
Building intbls for reservoirs is based on the global_wflow library, downloads HydroEngine timeseries each time and do some very specific calculations using attributes that may not be present in every datasets.
The idea is to maybe create a preprocess script that adds all parameters needed for wflow directly to the database and then hydroMT just reads directly the parameters from the database and doesn't do any intermediate calculations to produce the intbl files.
Note that apparently HydroEngine needs to have a HydroLAKES ID to be able to download JRC timeseries.

documentation minimal requirements and improve consistency of column names and units in reservoirs/lakes/glaciers
To be able to easily update the current shape data or use user supplied shape data for the reservoirs/lakes/glaciers it would be good to align the naming and units in these methods and document the minimal required data.

Currently the workflows are very data specific. for instance the area column for lakes/reservoirs is called 'Area_avg' with unit m2, while the area column for glaciers is called 'AREA' with unit km2.

@DirkEilander DirkEilander added enhancement New feature or request priority This issue should be fixed with priority labels Dec 8, 2021
@DirkEilander
Copy link
Contributor

While setup_reservoirs does accept any input data, for setup_lakes and setup_glaciers the names of the input data are hard coded.

This can give some funny error when trying to modify hydro_lakes properties in a local copy of the data and passing it with a local yml file, while the data_catalog.yml file in the model root already has a hydro_lakes entry which will overwrite the entry in your local file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority This issue should be fixed with priority
Projects
None yet
Development

No branches or pull requests

2 participants