Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waterbodies.py (reservoir parameter calculation) #35

Closed
jurianbeunk opened this issue Jun 14, 2021 · 1 comment
Closed

waterbodies.py (reservoir parameter calculation) #35

jurianbeunk opened this issue Jun 14, 2021 · 1 comment
Labels
bug Something isn't working priority This issue should be fixed with priority

Comments

@jurianbeunk
Copy link
Collaborator

jurianbeunk commented Jun 14, 2021

Line 259 in waterbodies.py:
dam_height = np.nanmax([gdf["Dam_height"].iloc[i], 0.0]
(or similar parameter calculations)

Will raise np.nanmax error TypeError: '>=' not supported between instances of 'NoneType' and 'float' when rdf contains NoneType data (i.e. no data).

Applying gdf = gdf.fillna(value=np.nan) before the parameter calculation loop, will result in np.nanmax returning 0.0 like it is supposed to and prevent the error from occuring.

@jurianbeunk jurianbeunk changed the title waterbodies.py waterbodies.py (reservoir parameter calculation) Jun 14, 2021
@DirkEilander DirkEilander added bug Something isn't working priority This issue should be fixed with priority labels Dec 3, 2021
@hboisgon
Copy link
Contributor

Closed with #130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority This issue should be fixed with priority
Projects
None yet
Development

No branches or pull requests

3 participants