Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement][API consistency] Kill( ), KillAll( ), methods are missing complete with callbacks param #589

Closed
floky opened this issue Jul 28, 2022 · 2 comments
Closed

[Improvement][API consistency] Kill( ), KillAll( ), methods are missing complete with callbacks param #589

floky opened this issue Jul 28, 2022 · 2 comments
Assignees
@Demigiant
Labels
enhancement

Comments

@floky
Copy link

floky commented Jul 28, 2022

At one point, Complete( ) methods on tweens/sequences received an extra super-useful param "withCallbacks". 馃帀

Considering that Kill( ) and KillAll( ) methods have the option to also complete the tweens, I think it would be a great API consistency improvement to also have the "withCallbacks" param added to the killing methods.

What do you think? 馃
@floky floky changed the title [Improvement][API consistency] Kill( ), KillAll( ), methods don't have the complete with callbacks flag as the Complete( ) methods do [Improvement][API consistency] Kill( ), KillAll( ), methods are missing complete with callbacks flag Jul 28, 2022
@floky floky changed the title [Improvement][API consistency] Kill( ), KillAll( ), methods are missing complete with callbacks flag [Improvement][API consistency] Kill( ), KillAll( ), methods are missing complete with callbacks param Jul 28, 2022
@Demigiant
Copy link
Owner

Yoyooo!!! Very good point, adding it to my todo list :)

@Demigiant Demigiant self-assigned this Jul 30, 2022
@floky
Copy link
Author

floky commented Aug 3, 2022

Yoyooo!!! Very good point, adding it to my todo list :)

馃榿 it's no big observation, but more of a quality of life improvement. 馃

@floky floky closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Demigiant Demigiant

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@floky @Demigiant