Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parish card not always given anchor link in top card #750

Closed
symroe opened this issue Apr 19, 2021 · 2 comments · Fixed by #770
Closed

Parish card not always given anchor link in top card #750

symroe opened this issue Apr 19, 2021 · 2 comments · Fixed by #770
Assignees

Comments

@symroe
Copy link
Member

symroe commented Apr 19, 2021

Compare

https://whocanivotefor.co.uk/elections/GL5%204HA/

with

https://whocanivotefor.co.uk/elections/GL5%201NA/

The first has a link to the parish council election and the card lower down the page. The second has the card, but no link.

@symroe symroe added this to Ready in Ordered backlog Apr 19, 2021
@michaeljcollinsuk michaeljcollinsuk self-assigned this Apr 19, 2021
@michaeljcollinsuk
Copy link
Contributor

michaeljcollinsuk commented Apr 26, 2021

@symroe as @pmk01 suggested the issue is that some of the elections may be uncontested, and we currently only display the anchor link if we know that it is contested. If I remove that condition, you then get a sentence that says "You will have three ballots to fill in" but get four links - is that confusing?
Screenshot 2021-04-26 at 15 17 25

I thought perhaps we could add some text to the link if we know they are uncontested - but because nothing is simple, there is also the third case where we don't know one way or the other if they are contested. I suppose here I could append some sort of message like:
Screenshot 2021-04-26 at 15 29 05

Added a WIP PR for the above #770

@pmk01
Copy link
Contributor

pmk01 commented Apr 26, 2021

Yes, to be honest I am fine with it as it is, but if you've already worked out the fix I agree entirely with your last suggestion!

Ordered backlog automation moved this from Ready to Done Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants