Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotbar curser disappears when scrolling outside of standard range in fluent mode. (Mod Incompatibility) #14

Open
HB-Stratos opened this issue May 17, 2024 · 5 comments
Labels

Comments

@HB-Stratos
Copy link

As the title says, I'm trying the mod in fluent mode, and I'd quite like to use it. But as it is now, it is unusable as the outer parts of both hotbars have the curser disappear.

Jdk-17.0.8.101-hotspot.2024.05.17.-.17.07.12.04.mp4

here's a log: 06AIGmm.txt
version 1.20.1 fabric with extended hotbar 3.0.0

This appears to be some sort of mod incompatibility as the issue does not occur if I test it on an empty modpack.

@HB-Stratos
Copy link
Author

Found the culprit. Smoothscroll breaks the fluent hotbar here. disabling smooth scroll hotbar (by setting the animation to zero) fixes the issue

@DenWav
Copy link
Owner

DenWav commented May 17, 2024

Alright, will take a look, thanks for the report.

@DenWav DenWav added the bug label May 17, 2024
@DenWav
Copy link
Owner

DenWav commented May 18, 2024

I have a workaround that fixes it halfway, at least making it usable, but I can't figure out how to do a full fix due to the mod calling rendering functions inside of a @ModifyArgs method, which is a pretty bad abuse of Mixins. If that was done as an inject instead I might be able to implement a workaround.

@SmajloSlovakian
Copy link

SmajloSlovakian commented Jun 4, 2024

hi... how would you like me to do this? the main function of the rendering functions is to render the selector on both sides of the hotbar when it is "rolling over" (going out of bounds)... i need the arguments of the rendering method to account for other mods changing them (like your mod presumably does)
i'm also going to implement a sort of half fix which is going to improve other potential mod compatibility issues by disabling the mask when the selector is stationary...

@SmajloSlovakian
Copy link

for now, i've made a commit to the dev branch, where i cut out the draw calls from the mixin into a different class you can mixin into to potentially fix the issue... hope this helps... if you have any questions or requests, please tell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants