Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObjectSharedArgumentsTests.cs:86-89: Make... #38

Closed
0pdd opened this issue Sep 18, 2022 · 3 comments
Closed

ObjectSharedArgumentsTests.cs:86-89: Make... #38

0pdd opened this issue Sep 18, 2022 · 3 comments
Labels
dev this mark means that this task can be assigned to developer role high priority The label shows that the ticket has a priority that is higher than average

Comments

@0pdd
Copy link

0pdd commented Sep 18, 2022

The puzzle 11-e081f816 from #11 has to be resolved:

ObjectToTest/tests/ObjectToTest.UnitTests/ObjectSharedArgumentsTests.cs

Lines 86 to 89 in cc1c853

* @todo #11:60m/DEV Make CircularReferenceInitProperties test to be green.
* Now the circular references not initialized properly and does not detect that shared object
* has circular reference in its fields or properties.
* It would nice to fix the test.

The puzzle was created by Maksym Shustov on 18-Sep-22.

Estimate: 60 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Sep 18, 2022
@MaxShustov
Merge pull request #36 from DenisZhukovski/circular-references
cc1c853 
Circular references
@0pdd 0pdd mentioned this issue Sep 18, 2022
Closed
@dzhukovski dzhukovski added dev this mark means that this task can be assigned to developer role high priority The label shows that the ticket has a priority that is higher than average labels Sep 19, 2022
This was referenced Sep 30, 2022
Closed
Closed
@0pdd
Copy link
Author

0pdd commented Sep 30, 2022

@0pdd 2 puzzles #46, #47 are still not solved.

@0pdd
Copy link
Author

0pdd commented Sep 30, 2022

@0pdd all 2 puzzles are solved here: #46, #47.

@0pdd
Copy link
Author

0pdd commented Oct 3, 2022

The puzzle 11-e081f816 has disappeared from the source code, that's why I closed this issue.

@0pdd 0pdd closed this as completed Oct 3, 2022
0pdd referenced this issue Oct 3, 2022
@DenisZhukovski
Cirular ref for shared objects init (#49)
fa37e30 
* code refactoring

* Implement circular reference properties initialization for shared arguments

* fix unit tests

* code refactoring

* update documentation
@0pdd 0pdd mentioned this issue Nov 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev this mark means that this task can be assigned to developer role high priority The label shows that the ticket has a priority that is higher than average
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0pdd @dzhukovski