Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect "Height map" algorithm for 4 or more axes. #341

Open
vitabu opened this issue Feb 4, 2020 · 4 comments
Open

Incorrect "Height map" algorithm for 4 or more axes. #341

vitabu opened this issue Feb 4, 2020 · 4 comments

Comments

@vitabu
Copy link

vitabu commented Feb 4, 2020

When using the grbl branch for 4 or more axes, the "z" coordinate in the "height map" algorithm is incorrectly parsed. The height map is filled with zeros. This is because the regular expression in ". * PRB: ([^,] *), ([^,] *), ([^] ^:] *)" in cap (3) takes everything up to the character ":" . You need something like ". * PRB: ([^,] *), ([^,] *), ([^] ^: ^,] *)".

@henpemaz
Copy link

I've had the same issue, I'm using grbl-Mega-5X for my 4-axis machine.

What I had to do was temporarily flash a vanilla GRBL firmware in order to get it working for a PCB job, and then switch back the firmware when I was done... That, or probe manually and fill in the values which got old super fast.

@henpemaz
Copy link

I am too lazy to download and set up a build environment for this project, so I opened the executable file, found and edited the regex string.
before: ([^]^:]*) after: ([^],:]*)

And it worked like a charm. That second ^ was redundant since the first one already states that the set is exclusion. It's very important that it has the same length after edited.

Editing executable files is dangerous. Try at your own risk!

@eightheads
Copy link

Thank you for this, it was driving me absolutely crazy! And thanks @henpemaz, I was able to edit the executable on my Mac to fix the issue. Seems like a quick fix.

@Slemi
Copy link

Slemi commented Feb 22, 2023

I am too lazy to download and set up a build environment for this project, so I opened the executable file, found and edited the regex string. before: ([^]^:]*) after: ([^],:]*)

And it worked like a charm. That second ^ was redundant since the first one already states that the set is exclusion. It's very important that it has the same length after edited.

Editing executable files is dangerous. Try at your own risk!

Any chance you can let us know step-by-step how to do this on windows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants