Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages with different GitHub package are not detected as installed #32

Open
yamanq opened this issue Mar 22, 2023 · 0 comments
Open

Comments

@yamanq
Copy link

yamanq commented Mar 22, 2023

System info

Librarian version : 1.8.1
R Version         : 4.2.0

What problem do you get?

When using stock on a package that has a different name from its GitHub repository, the installation is successful but check_installed does not detect it correctly

How do you reproduce the problem?

Stock a package with a different repository name from the package name
This repository contains SeuratDisk:

librarian::stock(mojaveazure/seurat-disk)

How to fix the issue

This can probably be directly fixed by reading the output of remotes::install_github, since it returns the package names. It might cause some control flow issues in other functions since seurat-disk is detected as not installed.

Additional Information

Relevant issue: https://github.com/r-lib/remotes/issues/55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant