Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are there dependencies? #45

Closed
vikr01 opened this issue Oct 16, 2018 · 5 comments
Closed

Why are there dependencies? #45

vikr01 opened this issue Oct 16, 2018 · 5 comments

Comments

@vikr01
Copy link
Contributor

vikr01 commented Oct 16, 2018

How is this package intended to be used with node?

From what I can tell, the javascript in src is being bundled into dist with webpack and since the target is web that means those dependencies will be bundled in as well -- which means they'd only need to be devDependencies so that the user doesn't need to install it when they install the package.

@hisk
Copy link
Contributor

hisk commented Oct 17, 2018

Hey @vikr01, 👋

Sorry for the delay! You are correct. Would you like to handle this one too? Thanks for your help so far, it's much appreciated! 😊

The only dependency left I guess should be just bootstrap since it's required by the main scss file only (as far as I remember) and it's not assumed to be installed. I'm not quite sure I understand what you mean with node, or that's what you were referring to?

@vikr01
Copy link
Contributor Author

vikr01 commented Oct 19, 2018

As far as I can see from the dist folder, there is no reference to bootstrap except in source maps. I don't think this project needs any dependencies at all.

@hisk
Copy link
Contributor

hisk commented Oct 22, 2018

(sorry for the delay)

@vikr01 Oh! I see what you mean now, and you're right. 😄 Some of the dependencies are redundant, except for Bootstrap which is used here.

@vikr01
Copy link
Contributor Author

vikr01 commented Oct 23, 2018

@hisk That's the SCSS in src, seems that gets bundled into the CSS in dist.

@hisk
Copy link
Contributor

hisk commented Oct 30, 2018

@vikr01 You are correct, but removing bootstrap is assuming that everyone is using the compiled styles only. That would force some developers that prefer to have the flexibility of compiling the assets and overriding certain styles to manually install bootstrap, which is a bit counter-intuitive.

@hisk hisk closed this as completed in 14a81d0 Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants