meteorReduxReducers will be nested after persist/REHYDRATE?

[Diwei-Chen]

Hi @JulianKingman ,

why would the meteorReduxReducers be nested stored after persist/REHYDRATE? If so, the size of meteorReduxReducers will theoretically be close to infinity if we keep refreshing the app?

Regards,

[JulianKingman]

Ah, right. This is probably because combineReducers creates new nested objects with the reducer name, which is also probably why you're getting error #28. So we need to deal with this a little more intelligently, because combining reducers the way it's done now will break a bunch of things (see conbineReducers docs: http://redux.js.org/docs/api/combineReducers.html). Basically, if combineReducers is used, we need to use MeteorStore.meteorReduxReducers.dispatch(...) instead of MeteorStore.dispatch(...), make sense? Interested in creating a new pull request?

You might be able to get away with something as simple as:

// line 86
const newReducers = (customReducers !== undefined) ? combineReducers({ ...customReducers, meteorReduxReducers }) : meteorReduxReducers;
const MeteorStore = createStore(newReducers, preloadedState, enhancer);
if (customReducers) MeteorStore.dispatch = MeteorStore.meteorReduxReducers.dispatch;

[Diwei-Chen]

@JulianKingman Sorry, I don't quite understand what's the difference between dispatched by MeteorStore and Meteor.meteorReduxReducers? Could you explain it with a bit more details, please? Also, we can't access to meteorReduxReducers as it is not directly under MeteorStore and it doesn't have a dispatch function as it is not a store object?

We tried very hard today and here are some screen shots:

We appreciate for your quick response :)

[JulianKingman]

I'm sorry, I led you astray there, it's not that the store gets nested, just the state. So now whenever you call MeteorStore.getState(), you get {meteorReduxReducers: {...}, customReducers: {...}}. So on line 95, in the rehydration step, calling MeteorStore.getState() is getting the whole state object, it needs to be MeteorStore.getState().meteorReduxReducers instead.

So if you replace instances of MeteorStore.getState() with this, it should work:

const getState = typeof customReducers !== 'undefined' ? MeteorStore.getState().meteorReduxReducers : MeteorStore.getState();
_.each(getState, (collection, key) => {
// etc...

[Diwei-Chen]

No worries. After added these two lines of codes, good news is, we can be able to restore all the customReducers' states properly, but all the previous states would be nested into meteorReduxReducers again. Then after several times of refreshing the app, the size of meteorReduxReducers will increase largely.

Is this problem caused by the 'rehydrated' step, which is from line 95 - 110? As the payload of current persist/REHYDRATE action doesn't overwrite prev state correctly?

[JulianKingman]

How is this working in v2, I haven't tested?

[Diwei-Chen]

Thanks @JulianKingman

This problem still exists