Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/external link #11

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Feat/external link #11

merged 2 commits into from
Apr 5, 2024

Conversation

kristoferfannar
Copy link
Contributor

@kristoferfannar kristoferfannar commented Apr 5, 2024 •
edited

Description

created core component

<ExternalLink
  url: string
>
</ExternalLink>

which opens a url in user's external browser

Use Tauri's api/shell/open method which opens a url an external browser. The backend has to permit this method to be called in tauri.conf.json.

Testing

馃馃槀

@kristoferfannar
Copy link
Contributor Author

pls squash merge

@lsig
Copy link
Contributor

lsig commented Apr 5, 2024

LGTM!!!

@lsig lsig merged commit a71c56b into main Apr 5, 2024
3 checks passed
@kristoferfannar kristoferfannar deleted the feat/externalLink branch April 6, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsig lsig Awaiting requested review from lsig

@halli21 halli21 Awaiting requested review from halli21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kristoferfannar @lsig