feat: mvp router login brute force impl #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get latest updates from main
when button is pressed, check_admin_creds is called in the backend, which was originally named scan_http_port
|
New router page: 
|
lsig
reviewed
Apr 7, 2024
| if got_redirect_response(text.as_str()) { | ||
| let redirected = get_redirected_response(text.as_str(), client.clone(), address.as_str()) | ||
| .await | ||
| .unwrap(); |
There was a problem hiding this comment.
Use a ? to propagate the error instead of causing a panic if the unwrap fails
lsig
reviewed
Apr 7, 2024
| fn find_endpoints_from_code(code: &str) -> Vec<String> { | ||
| // find all possible endpoints within the javascript code | ||
| let regex_pattern = r#""(/[a-zA-Z0-9\/]+)""#; | ||
| let rx = Regex::new(regex_pattern).unwrap(); |
There was a problem hiding this comment.
Code might panic if regex is not initilized. This is unlikely but maybe better to handle with a result type which returns an error. Then this could look something like this:
-> Result<Vec, Err>
let rx = Regex::new(regex_pattern)?;
There was a problem hiding this comment.
Also applies to the find_script_src
| .send() | ||
| .await; | ||
|
|
||
| return request.unwrap(); |
There was a problem hiding this comment.
Unwrap on return can be dangerous
|
Fixed! |
…tsFail get latest updates from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, a minimally viable version of an admin brute force attack is attempted on the user's router, notifying the user if valid credentials were found.
When activated: