You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Status is high because it blocks the reference_path PR
What is the current behavior?
Given the following error :
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem Avoid reference to other packages
I unsure if this there is an expected behavior, but i guess this should not fail as it is covered by the test surfaces/test_cylindrical_surface3d.TestCylindricalSurface3D.test_contour3d_to_2d
What is the motivation / use case for changing the behavior?
This is problematic because the test failed when I added some argument to the init functions which misaligned the two signatures :
It means that before that, we were able to generate an Arc2D as well as a FullArc2D, but by giving respectively point1 to FullArc2D's start_end and point3 to reference_path.
I could make it work by removing either the reference_path or name argument (as it was done before), but this is plainly wrong
Possible fixes
Either override FullArc2D's method or prevent user from creating a FullArc2D from 3 points.
I am going to propose a fix with the former, here
Please tell us about your environment:
branch: dev
commit:
python version: 3.9
The text was updated successfully, but these errors were encountered:
Status is high because it blocks the reference_path PR
Given the following error :
I unsure if this there is an expected behavior, but i guess this should not fail as it is covered by the test
surfaces/test_cylindrical_surface3d.TestCylindricalSurface3D.test_contour3d_to_2d
This is problematic because the test failed when I added some argument to the init functions which misaligned the two signatures :
The following call can have Arc2D or FullArc2D as
cls
:It means that before that, we were able to generate an Arc2D as well as a FullArc2D, but by giving respectively point1 to FullArc2D's start_end and point3 to reference_path.
I could make it work by removing either the reference_path or name argument (as it was done before), but this is plainly wrong
Either override FullArc2D's method or prevent user from creating a FullArc2D from 3 points.
I am going to propose a fix with the former, here
Please tell us about your environment:
The text was updated successfully, but these errors were encountered: