Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor edges normal_vector and direction_vector methods #995

Open
1 of 2 tasks
GabrielJMS opened this issue Aug 14, 2023 · 0 comments
Open
1 of 2 tasks

Refactor edges normal_vector and direction_vector methods #995

GabrielJMS opened this issue Aug 14, 2023 · 0 comments

Comments

@GabrielJMS
Copy link
Contributor

  • I'm submitting a ...

    • bug report
    • feature request
  • What is the current behavior?

The edges objects possess the methods normal_vector(), unit_normal_vector(), direction_vector(), and unit_direction_vector(). It is possible to simplify these four methods into just two methods: tangent() and normal(). These two new methods would accept the same parameters as the previously mentioned methods, with an additional optional parameter to specify whether the result should be normalized.

  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem Avoid reference to other packages

  • What is the expected behavior?

  • What is the motivation / use case for changing the behavior?

  • Simplify and mutualize

  • Possible fixes

  • Please tell us about your environment:

    • branch:
    • commit:
    • python version:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant