Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe-to-dismiss on sheets can sometimes dismiss the parent sheet #10417

Open
bhollis opened this issue May 13, 2024 · 5 comments
Open

Swipe-to-dismiss on sheets can sometimes dismiss the parent sheet #10417

bhollis opened this issue May 13, 2024 · 5 comments

Comments

@bhollis
Copy link
Contributor

bhollis commented May 13, 2024

We've had multiple reports that people who are vigorously scrolling in a scrollable sheet will see that sheet dismiss - and dismiss the parent sheet as well. The common complaint seems to be the loadout editor and the mod selection sheet - people scroll mods and it dismisses the loadout sheet entirely, losing the in-progress loadout. This is clearly a bug but it has been hard to reproduct.

Linking #9903

@ryan-rushton
Copy link
Contributor

ryan-rushton commented May 18, 2024

I took a stab at reproducing it in the PWA and had no luck. Any inclination of apple vs android phones and or browsers?

@bhollis
Copy link
Contributor Author

bhollis commented May 18, 2024

We've had reports from both but I can't reproduce on iPhone. I bought a Samsung phone to try and see if that's easier to repro on.

@ryan-rushton
Copy link
Contributor

The only think I could see as a maybe was the velocity capture point where we hide the sheet if the downward velocity is fast enough. It is possible to drag the sheet close from clicking anywhere as the drag handle is on the container. I could actually get that to trigger and close the sheet via dragging an item in it, but I couldn't replicate the behaviour reported exactly. I had to be very deliberate and it also only closed the mod sheet (I was using edit loadout + add mods).

@bhollis
Copy link
Contributor Author

bhollis commented May 18, 2024

Yeah, I'm not as worried about "it's too easy to close the sheet", I'm worried about closing one sheet also closing its parent.

@ryan-rushton
Copy link
Contributor

Yeah agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants