Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smarter bucket detection of dummy items #10429

Open
nev-r opened this issue May 18, 2024 · 1 comment
Open

smarter bucket detection of dummy items #10429

nev-r opened this issue May 18, 2024 · 1 comment

Comments

@nev-r
Copy link
Member

nev-r commented May 18, 2024

image

this gun's sockets are being displayed as general instead of weapon,
because its bucket.inWeapons is not true,
because it's a dummy that belongs in the forbidden bucket.

this fake dimitem's bucket prop (which is supposed to describe where it belongs, not where it is)
could be corrected by matching name and item type against a non-dummy in the defs

@bhollis
Copy link
Contributor

bhollis commented May 21, 2024

We have a similar name-matching thing for collections, I bet it could be reused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants