Enhanced Bipod stat penalties are displayed incorrectly

[Prometheus3375]

DIM Version

Version 8.21.1 (release), built on 27.05.2024, 20:49:58

Browser Details

Chrome 124.0.0.0

OS Details

Windows 10

Describe the bug

Variant w/o Bipod.

Variant w/ Bipod.
Blast radius: 95 -> 65 (correct)
Reload speed: 38 -> 18 (correct)

Variant w/ Enhanced Bipod.
Blast radius: 95 -> 40 (incorrect, should be 70)
Reload speed: 38 -> 3 (incorrect, should be 23)

It looks like when calculating penalties for Enhanced Bipod, penalties of regular Bipod are also included. 95 - (30 + 25) = 40 and 38 - (20 + 15) = 3.

Logs

No response

[bhollis]

https://data.destinysets.com/i/InventoryItem:2282937672

So that's what Bungie says. isConditionallyActive of course is the trick - we can't know what the conditions are.

[Prometheus3375]

I see, Light.gg also has this issue, but foundry displays it correctly, maybe they manually fixed that.

[bhollis]

We could check all plugs and see if we can get away with a rule of "if the same stat is present twice, take the second occurrence"

[bhollis]

Hmm, this is a bit more complicated than expected. For example, here's Enhanced Lasting Impression: https://data.destinysets.com/i/InventoryItem:1167468626

It does appear to grant 55 blast radius.

[bhollis]

And interestingly, Enhanced Bipod was fixed in the definitions.