Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enterprising Explorer II completed but subsequently still shows as +2 power. #10586

Closed
Endracion opened this issue Jun 20, 2024 · 8 comments · Fixed by #10617
Closed

Enterprising Explorer II completed but subsequently still shows as +2 power. #10586

Endracion opened this issue Jun 20, 2024 · 8 comments · Fixed by #10617
Labels

Comments

@Endracion
Copy link

Endracion commented Jun 20, 2024

DIM Version

Version 8.24.0.3445 (beta), built on 6/19/2024, 1:21:13 PM

Browser Details

Chrome 125.0.0.0

OS Details

Windows 10

Describe the bug

image

Once the pinnacle is completed, it does indeed become a Tier 2 powerful, but is the detail display here supposed to be like that? And should it still appear as a pinnacle after it's been completed? Or does it mean that it can be cycled 2 more times and it becomes Pinnacle again?

Logs

No response

@Endracion Endracion added the Bug label Jun 20, 2024
@bhollis
Copy link
Contributor

bhollis commented Jun 20, 2024

There's definitely some complexity about how rewards work, some of which we can't easily display correctly here. For example these multi phase milestones give rewards based on in game scripts we don't have access to. We do have some improvements in progress for milestones though.

@Endracion
Copy link
Author

I see, then feel free to close this if it's not considered a bug.

@bhollis
Copy link
Contributor

bhollis commented Jun 22, 2024

Can you tell me if it's any better at https://pr.dim.gg/10578/ ?

@Endracion
Copy link
Author

It looks the same to me?

image

@delphiactual
Copy link
Contributor

try now

@Endracion
Copy link
Author

Endracion commented Jun 22, 2024

Ok, I see it gets shifted to powerful +0 in my case on the character that already has the pinnacle completed, which is great IMO.
image

It lists multiple tier 2 powerfuls though, I'm not sure it's repeatable that many times? But I haven't tried either.

@bhollis
Copy link
Contributor

bhollis commented Jun 22, 2024

OK, we'll have to figure out how to tie rewards to the phase the quest is at, if that's even possible.

@Endracion
Copy link
Author

The first quest is Explorer I (Pinnacle) and next one is Explorer II (Powerful Tier 2), so maybe there's an Explorer III, I think the updated version above is still better, because it at least removes it from the Pinnacle rewards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants