Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Mass Lock/Tag via filtered results #3241

Closed
BasicNullification opened this issue Oct 17, 2018 · 3 comments
Closed

Unable to Mass Lock/Tag via filtered results #3241

BasicNullification opened this issue Oct 17, 2018 · 3 comments
Labels

Comments

@BasicNullification
Copy link

In the 4.74.0 release, the following feature was added:

Lock and unlock items matching your current search from the same menu you use for tagging them

However, filtering items by, let's say, tag:infuse and then selecting unlock from the tag icon in the search bar will show the user the following message:

Unlocked 0 Items

Even when there are locked items matching the search result.

enter image description here

As shown in the above, the search result of tag:infuse is:locked would no longer have matched the is:locked portion if the unlock update went through, but they remained locked.

@duckmanBR
Copy link
Contributor

Trying to reproduce this I also discovered that tagging is also not working, so none of the "mass" options are working. And tagging doesn't show the info popup...

I'm on mobile, so can't check console for error messages.

@duckmanBR duckmanBR changed the title Unable to Mass Lock / Unlock via filtered results Unable to Mass Lock/Tag via filtered results Oct 17, 2018
@duckmanBR
Copy link
Contributor

duckmanBR commented Oct 17, 2018

So looking a little further, looks like the problem is that the combo selection is not properly triggering a refresh.
For the tag, I need to manually refresh (or just be luck for DIM auto refresh) to see the changes.
For the lock, it's taking a little longer (maybe some delay on Bungie side since lock is trough API while tag is 100% DIM?), but 1-2 manual refreshes are needed for the items reflect the (un)lock action.

TL;DR: DIM is correctly applying the option selected, but something is delaying the user to see it done.

@bhollis
Copy link
Contributor

bhollis commented Oct 17, 2018

Yeah lock state isn’t modeled separately in the Redux store yet so we need to force a store update after locking/unlocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants