Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precision handcannon magazines are especially wrong #6395

Closed
nev-r opened this issue Jan 1, 2021 · 4 comments
Closed

Precision handcannon magazines are especially wrong #6395

nev-r opened this issue Jan 1, 2021 · 4 comments
Assignees

Comments

@nev-r
Copy link
Member

nev-r commented Jan 1, 2021

but i figured out why!

https://www.bungie.net/en/Explore/Detail/News/49676

Precision Hand Cannon
(180 RoF) magazine scaled up by 37 percent.

this is not reflected in definitions, it is applied as an effect. we can account for it with a multiplier, and i think we should. because 37% error is a lot to hand-wave away, when it's known both how and why we should adjust it. this one we have the supporting info for, it's not simply data quirks.

@nev-r nev-r added the Bug label Jan 1, 2021
@nev-r
Copy link
Member Author

nev-r commented Jan 1, 2021

adjusting after interpolation is the one that gets some values right
image

@bhollis
Copy link
Contributor

bhollis commented Jan 5, 2021

That's a real bummer. I support fixing it on our side if we can get it right.

Couple thoughts on where to apply the scale:

  1. Have you applied banker's rounding to the scale-up?
  2. Should we scale up the interpolated value, then round, or round, then scale, then round again?

@nev-r
Copy link
Member Author

nev-r commented Jan 9, 2021

rounding twice is a great idea i hadn't tried. tried banker and i couldn't get meaningfully better or worse, but i will retry with the other idea.

@bhollis
Copy link
Contributor

bhollis commented Mar 8, 2023

Is this still in effect?

@bhollis bhollis closed this as not planned Won't fix, can't repro, duplicate, stale Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants