Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "This could take a while" notes incorrectly imply that nix builds most (all) packages from source #166

Open
Sciencentistguy opened this issue Jan 23, 2023 · 2 comments

Comments

@Sciencentistguy
Copy link

The phrasing of the text of the "this could take a while" boxes is unclear to me, in that it seems to suggest that most of the time nix will build a package.

With the nix run and nix develop examples given it is overwhelmingly likely that the packages will be cache hits. (Unless the user is on a wacky architecture or has manually removed hydra as a cache, i guess)

@lucperkins
Copy link
Member

@Sciencentistguy Yes, this is indeed something that we should make more clear because it undersells Nix to suggest otherwise. I'll rework the text a bit.

@willbush
Copy link
Contributor

I also wonder if it being a warning is a bit much, and subsequent warnings after 2.nix-run.mdx seem redundant.

src/pages/start/2.nix-run.mdx
23   <Admonition warning title="This could take a while" id="nix-run-loading" client:load>

src/pages/start/4.nix-develop.mdx
22   <Admonition warning title="This could take a while" id="nix-develop-loading" client:load>

src/pages/start/5.nix-search.mdx
29   <Admonition warning title="This could take a while" id="nix-search" client:load>
73   <Admonition warning title="This could take a while" id="nix-search" client:load>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants