Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for moon apogee and perigee #122

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Add support for moon apogee and perigee #122

merged 1 commit into from
Dec 1, 2020

Conversation

Deuchnord
Copy link
Member

@Deuchnord Deuchnord commented Nov 8, 2020 •
edited

Q A
Bug fix? no
New feature? yes
Related issues Fix #72
Has BC-break no
License GNU AGPL-v3

Checklist:

  • I have updated the manpages

@Deuchnord Deuchnord self-assigned this Nov 8, 2020
@Deuchnord Deuchnord added enhancement New feature or request 🌠 events labels Nov 8, 2020
@Deuchnord Deuchnord force-pushed the issue72-moon-apogee-perigee branch 5 times, most recently from 1570caa to 06d6c9d Compare November 8, 2020 16:11
@Deuchnord
Copy link
Member Author

Deuchnord commented Nov 9, 2020 •
edited

Unit tests currently fail because of duplication of the PERIGEE Events.
Should be fixed with skyfielders/python-skyfield#475.

@Deuchnord Deuchnord force-pushed the issue72-moon-apogee-perigee branch 9 times, most recently from 55dccb1 to f527460 Compare November 20, 2020 13:09
@Deuchnord Deuchnord marked this pull request as ready for review December 1, 2020 11:15
@Deuchnord Deuchnord merged commit 7e0d8b1 into features Dec 1, 2020
@Deuchnord Deuchnord deleted the issue72-moon-apogee-perigee branch December 1, 2020 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Deuchnord Deuchnord

Labels
enhancement New feature or request 🌠 events
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Deuchnord