Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make docker image #137

Merged
merged 1 commit into from Feb 13, 2021
Merged

Make docker image #137

merged 1 commit into from Feb 13, 2021

Conversation

nicfb
Copy link
Contributor

@nicfb nicfb commented Jan 31, 2021

Q A
Bug fix? no
New feature? yes
Related issues Fix #19
Has BC-break no
License GNU AGPL-v3

Checklist:

  • [ x] I have updated the manpages

This PR adds a Docker image for Kosmorro. It will be added to Docker Hub on push to master.

Deuchnord
Deuchnord requested changes Feb 1, 2021
View reviewed changes
Copy link
Member

@Deuchnord Deuchnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

requirements.txt Outdated Show resolved Hide resolved
README.md Outdated

Get the official Kosmorro Docker image by running `docker pull kosmorro/kosmorro`.
Now that you have the image, you can run it with `docker run -it kosmorro`.
Finally, run Kosmorro by executing `python kosmorro` in the container.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get rid of the python call by adding /home/kosmorro in the container's default $PATH:

RUN echo "PATH=/home/kosmorro:$PATH" >> .bashrc

and by adding the execution permission to the kosmorro file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added this to the Dockerfile using the ENV instruction.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this resolved now?

README.md Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
Deuchnord
Deuchnord reviewed Feb 2, 2021
View reviewed changes
Dockerfile Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
@Deuchnord
Copy link
Member

Thanks!
I'm doing some tests on my side and looking at what's wrong with the tests in #139, and I'll merge this this week 🙂

@nicfb
Copy link
Contributor Author

nicfb commented Feb 3, 2021

Awesome, thanks for your help!

@Deuchnord
Copy link
Member

I've just merged the fixes for the CI.
Can you rebase your branch on master, squash your commits and change its message to comply with the Conventional Commit, please? 🙂

If you need help, feel free to ask!

@nicfb
Copy link
Contributor Author

nicfb commented Feb 5, 2021

Sure! I'm thinking the type I would use here would be "docs". Is that right?

@Deuchnord
Copy link
Member

You can use the feat type, since to me, it is a new feature :)

@coveralls
Copy link

coveralls commented Feb 6, 2021 •
edited

Coverage Status

Coverage remained the same at 90.363% when pulling 273b228 on nicfb:make-docker-image into 86983c9 on Kosmorro:master.

@Deuchnord
Copy link
Member

Thank you for your PR, I'll look at it this weekend :)

@Deuchnord
Copy link
Member

Thank you for your work, @nicfb! 🚀

@Deuchnord Deuchnord merged commit a6d3575 into Kosmorro:master Feb 13, 2021
Deuchnord added a commit that referenced this pull request Feb 13, 2021
@Deuchnord
Revert "feat: add official Docker image (#137)"
6f4504c 
This reverts commit a6d3575.
@Deuchnord Deuchnord mentioned this pull request Feb 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deuchnord Deuchnord Deuchnord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make a Docker image
3 participants
@nicfb @Deuchnord @coveralls