feat: guess output format from output file extension #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deuchnord
requested changes
Aug 17, 2021
|
I think I have addressed all of your comments. Let me know if there's anything else you see that needs fixing! |
Deuchnord
requested changes
Aug 23, 2021
guess output format based on output file extension check for empty output file default to .txt if no file extension provided change default output format back to txt add tests update man page fix default output format directly return output dumper use keys from dumpers in key error message fix man pages prevent output format from being overridden use first dumper key as default format update messages and formatting update help message for format argument specify list type in InvalidOutputFormat exception make default output format more apparent update messages
|
Thank you! |
|
It's all good for me, just caught a little bug when exporting to JSON without giving a position, but it's not related to this PR and should be fixed in a 0.10.2 version, so we can merge this! Thank you for this amazing work! 😄 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
guess output format based on output file extension
check for empty output file
default to .txt if no file extension provided
add tests
update man page
Checklist:
This PR makes it so the
--outputargument optional. If it is not given, the file extension from the output file will be used to guess the requested format.