Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename fields in the JSON response for more coherence #35

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

Deuchnord
Copy link
Member

BREAKING CHANGE: the fields "details" and "ephemerides" have been switched.

Q A
Bug fix? no
New feature? yes
Related issues
Has BC-break yes
License GNU AGPL-v3

BREAKING CHANGE: the fields "details" and "ephemerides" have been switched.
@Deuchnord Deuchnord added the enhancement New feature or request label Dec 9, 2019
@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #35 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #35     +/-   ##
=========================================
+ Coverage   77.46%   77.67%   +0.2%     
=========================================
  Files           5        5             
  Lines         324      327      +3     
  Branches       45       45             
=========================================
+ Hits          251      254      +3     
  Misses         62       62             
  Partials       11       11
Impacted Files Coverage Δ
kosmorrolib/dumper.py 86.07% <100%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e49fe96...4029ba9. Read the comment docs.

@Deuchnord Deuchnord merged commit 5a1bbca into master Dec 9, 2019
@Deuchnord Deuchnord deleted the fix-json-naming branch December 9, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant