Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for maximal elongations of Mercury and Venus #53

Merged
merged 1 commit into from
Feb 22, 2020

Conversation

Deuchnord
Copy link
Member

Q A
Bug fix? no
New feature? yes
Related issues Fix #49
Has BC-break no
License GNU AGPL-v3

@Deuchnord Deuchnord added enhancement New feature or request 🌠 events labels Feb 19, 2020
@Deuchnord Deuchnord self-assigned this Feb 19, 2020
@Deuchnord Deuchnord linked an issue Feb 19, 2020 that may be closed by this pull request
3 tasks
@Deuchnord Deuchnord force-pushed the maximal-elongation branch 5 times, most recently from b934f51 to 10a261c Compare February 21, 2020 18:47
@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #53 into features will increase coverage by 0.38%.
The diff coverage is 90.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features      #53      +/-   ##
============================================
+ Coverage     81.88%   82.27%   +0.38%     
============================================
  Files             8        8              
  Lines           508      536      +28     
  Branches         81       88       +7     
============================================
+ Hits            416      441      +25     
  Misses           77       77              
- Partials         15       18       +3
Impacted Files Coverage Δ
kosmorrolib/core.py 96% <ø> (+5.09%) ⬆️
kosmorrolib/events.py 100% <100%> (ø) ⬆️
kosmorrolib/ephemerides.py 53.63% <66.66%> (-1.51%) ⬇️
kosmorrolib/data.py 88.39% <90%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 410c553...9dbc093. Read the comment docs.

@Deuchnord Deuchnord force-pushed the maximal-elongation branch 3 times, most recently from a382669 to 4be438f Compare February 21, 2020 19:25
@Deuchnord Deuchnord merged commit 84face5 into features Feb 22, 2020
@Deuchnord Deuchnord deleted the maximal-elongation branch February 22, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🌠 events
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximal elongation
1 participant