Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display a graph in the PDF output for the ephemerides #82

Merged
merged 1 commit into from
May 12, 2020
Merged

Display a graph in the PDF output for the ephemerides #82

merged 1 commit into from
May 12, 2020

Conversation

Deuchnord
Copy link
Member

@Deuchnord Deuchnord commented Apr 26, 2020 •
edited
Loading

Q A
Bug fix? no
New feature? yes
Related issues N/A
Has BC-break no
License GNU AGPL-v3

Checklist:

  • I have updated the manpage

@Deuchnord Deuchnord changed the title feat: display a graph in the PDF output for the ephemerides Display a graph in the PDF output for the ephemerides Apr 26, 2020
@Deuchnord Deuchnord self-assigned this Apr 26, 2020
@Deuchnord Deuchnord added the enhancement New feature or request label Apr 26, 2020
@Deuchnord Deuchnord added this to In progress in Version 1.0.0 via automation Apr 26, 2020
@Deuchnord Deuchnord added this to the v0.8 milestone Apr 26, 2020
@codecov
Copy link

codecov bot commented Apr 26, 2020 •
edited
Loading

Codecov Report

Merging #82 into features will increase coverage by 0.46%.
The diff coverage is 92.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features      #82      +/-   ##
============================================
+ Coverage     85.71%   86.18%   +0.46%     
============================================
  Files             8        8              
  Lines           553      579      +26     
  Branches         89       94       +5     
============================================
+ Hits            474      499      +25     
- Misses           60       61       +1     
  Partials         19       19
Impacted Files Coverage Δ
kosmorrolib/dumper.py 79.03% <92.85%> (+2.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef2e9e4...4ea148e. Read the comment docs.

@Deuchnord Deuchnord force-pushed the pdf-ephemerides-graph branch 4 times, most recently from eb12acc to 12c3e6e Compare May 12, 2020 11:48
feat: display a graph in the PDF output for the ephemerides
4ea148e 
Show a graph instead of a table for the ephemerides in the PDF output
@Deuchnord Deuchnord marked this pull request as ready for review May 12, 2020 11:57
@Deuchnord Deuchnord merged commit e5cc1ab into features May 12, 2020
Version 1.0.0 automation moved this from In progress to Done May 12, 2020
@Deuchnord Deuchnord deleted the pdf-ephemerides-graph branch May 12, 2020 19:47
@Deuchnord Deuchnord mentioned this pull request May 13, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Deuchnord Deuchnord

Labels
enhancement New feature or request
Projects
Version 1.0.0
  
Done
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Deuchnord