Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item got duped when you break the chest #24

Closed
cupang-afk opened this issue Dec 31, 2022 · 3 comments
Closed

Item got duped when you break the chest #24

cupang-afk opened this issue Dec 31, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@cupang-afk
Copy link

How to produce

  1. kill yourself
  2. go to your death location
  3. break the death chest
  4. voila

i have tried this for like 10 more times
image

other behaviour (open the chest -> take all item -> chest break/disappear automaticaly) work as intended

config:

# The Configuration file of Death Chest
#    In this file you can customize the plugin.
#

# Do not touch this!
config-version: 2

# I recommend leaving this on true to receive notification when I have performance improvements.
update-checker: true
duration-format: 'mm:ss'
# The expiration of the chest in seconds.
# You can deactivate the expiration by setting the value to -1
expiration: 1800
# If this feature is enabled all caught items will be dropped if the chest is expired.
drop-items-after-expiration: true

# Here you can modify the inventory which opens when you right-click the death chest. You can use color codes with '&'
# in the title and change the inventory size by changing the size value.
inventory:
  title: 'Death Chest'
  # Possible values are: constant and flexible
  # constant: the size of the inventory is always 45 slots large
  # flexible: the size of the inventory depends on the items which had the player in the inventory.
  size: flexible

# This section is for handling the hologram function in this plugin. You can remove this section to disable the feature,
# or you set the 'enabled' option to false
# This feature is only available if you have a supported hologram plugin installed.
hologram:
  enabled: true
  # If you add lines you have to increase this value. This values depends on the hologram
  # plugin and the distance between the plugin
  height: 2.3
  # Support for {player_name}: Name
  #             {player_displayname}: Displayname
  #             {duration}: Time left
  lines:
    - '&7&lR.I.P'
    - '${player_name}'
    - '&3-&6-&3-&6-&3-&6-&3-'
    - '${duration}'

# This section is for handling the particle function in this plugin. You can remove this section to disable the feature,
# or you set the 'enabled' option to false
particle:
  enabled: true
  radius: 1.0
  count: 32
  # Maximum is 20
  speed: 20.0

# This section is for handling the block breaking function in this plugin. You can remove this section to disable the feature,
# or you set the 'enabled' option to false
# This feature is only available if you have ProtocolLib installed.
break-effect:
  enabled: true
  view-distance: 20.0

# This section is for handling the notification function in this plugin. You can remove this section to disable the feature,
# or you set the 'enabled' option to false.
# This feature sends a message to the dead player. Here you can inform the player about the chest and their expiration.
# You can send the death coordination by using the placeholders: ${x} ${y}, ${z} and ${world}
player-notification:
  enabled: true
  message: |-
    &7You died. Your items were put into a chest which disappears after &c30 minutes&7! ${world}: ${x} ${y} ${z} 
# Available Placeholders:
# ${player_name} : shows the player name
# ${player_displayname} : shows the player display name (Maybe with prefix)
# ${x}, ${y}, ${z}, ${world} : shows the coordinates of the death location
global-notification:
  enabled: false
  message: |-
    &7${player_name} died at ${x} ${y} ${z} in ${world}
# Available Placeholders:
# ${player_name} : shows the player name
# ${player_displayname} : shows the player display name (Maybe with prefix)
# ${x}, ${y}, ${z}, ${world} : shows the coordinates of the death location
# To disable the death message change "enabled" to true and remove the message option.
change-death-message:
  enabled: false
  message: |-
    &7${player_name} died at ${x} ${y} ${z} in ${world}
# This section configures the activation of this plugin for specific worlds.
world-filter:
  # Possible values: blacklist, whitelist
  filter: blacklist
  worlds:
    - disabled_world

# Set this option to true if you want to protect the death chests against explosions.
blast-protection: true

# This option protects the death chest against thieves if the player has the specific permission and the thief
# not the bypass permission.
# For this option is Vault required.
chest-protection:
  enabled: false
  permission: deathchest.thiefprotected
  bypass-permission: deathchest.thiefprotected.bypass
  # On this website you can find a list of all sounds which is implemented in SpigotMC
  # @see https://hub.spigotmc.org/javadocs/spigot/org/bukkit/Sound.html
  # If you want to disable the sound or the message, you can delete this options
  sound: BLOCK_CHEST_LOCKED;1.0;1.0
  message: |-
    &cYour are not permitted to open this chest```
@cupang-afk
Copy link
Author

after doing a little bit of "killing myself"

i find the bug is related to drop-items-after-expiration: true feature

when i set drop-items-after-expiration: false in the config
the dupe is fixed

@DevCyntrix
Copy link
Owner

Thank you very much for your report. I will fix it as soon as possible!

@DevCyntrix
Copy link
Owner

This bug should be fixed with the newest version 1.5.15. Thank you very much!

@DevCyntrix DevCyntrix self-assigned this Mar 27, 2023
@DevCyntrix DevCyntrix added the bug Something isn't working label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants