Skip to content

Commit

Permalink
refactor(react-grid): Rename detailToggleTemplate to detailToggleCell…
Browse files Browse the repository at this point in the history
…Template (#146)

BREAKING CHANGE:

We renamed the `detailToggleTemplate` property of the TableRowDetail plugin to `detailToggleCellTemplate` to make it consistent with the `detailToggleCellWidth` property.
  • Loading branch information
gsobolev committed Jun 16, 2017
1 parent 0d796d9 commit bd49b0e
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
Expand Up @@ -3,12 +3,12 @@ import { TableRowDetail as TableRowDetailBase } from '@devexpress/dx-react-grid'
import { TableDetailToggleCell } from '../templates/table-detail-toggle-cell';
import { TableDetailCell } from '../templates/table-detail-cell';

const detailToggleTemplate = props => <TableDetailToggleCell {...props} />;
const detailToggleCellTemplate = props => <TableDetailToggleCell {...props} />;
const detailCellTemplate = props => <TableDetailCell {...props} />;

export const TableRowDetail = props => (
<TableRowDetailBase
detailToggleTemplate={detailToggleTemplate}
detailToggleCellTemplate={detailToggleCellTemplate}
detailCellTemplate={detailCellTemplate}
detailToggleCellWidth={25}
{...props}
Expand Down
Expand Up @@ -3,12 +3,12 @@ import { TableRowDetail as TableRowDetailBase } from '@devexpress/dx-react-grid'
import { TableDetailToggleCell } from '../templates/table-detail-toggle-cell';
import { TableDetailCell } from '../templates/table-detail-cell';

const detailToggleTemplate = props => <TableDetailToggleCell {...props} />;
const detailToggleCellTemplate = props => <TableDetailToggleCell {...props} />;
const detailCellTemplate = props => <TableDetailCell {...props} />;

export const TableRowDetail = props => (
<TableRowDetailBase
detailToggleTemplate={detailToggleTemplate}
detailToggleCellTemplate={detailToggleCellTemplate}
detailCellTemplate={detailCellTemplate}
detailToggleCellWidth={42}
{...props}
Expand Down
2 changes: 1 addition & 1 deletion packages/dx-react-grid/docs/reference/table-row-detail.md
Expand Up @@ -14,7 +14,7 @@ Name | Type | Default | Description
-----|------|---------|------------
template | (args: [DetailContentArgs](#detail-content-args)) => ReactElement | | A component that renders row details
detailCellTemplate | (args: [DetailCellArgs](#detail-cell-args)) => ReactElement | | A component that renders a detail cell
detailToggleTemplate | (args: [DetailToggleArgs](#detail-toggle-args)) => ReactElement | | A component that renders the detail toggle control
detailToggleCellTemplate | (args: [DetailToggleArgs](#detail-toggle-args)) => ReactElement | | A component that renders the detail toggle control
detailToggleCellWidth | number | | Specifies the detail toggle cell width
rowHeight | number &#124; string | 'auto' | Specifies the detail row height

Expand Down
6 changes: 3 additions & 3 deletions packages/dx-react-grid/src/plugins/table-row-detail.jsx
Expand Up @@ -8,7 +8,7 @@ export class TableRowDetail extends React.PureComponent {
const {
rowHeight,
template,
detailToggleTemplate,
detailToggleCellTemplate,
detailCellTemplate,
detailToggleCellWidth,
} = this.props;
Expand Down Expand Up @@ -40,7 +40,7 @@ export class TableRowDetail extends React.PureComponent {
expandedRows,
setDetailRowExpanded,
...restParams
}) => detailToggleTemplate({
}) => detailToggleCellTemplate({
...restParams,
expanded: isDetailRowExpanded(expandedRows, getRowId(row)),
toggleExpanded: () => setDetailRowExpanded({ rowId: getRowId(row) }),
Expand Down Expand Up @@ -71,7 +71,7 @@ export class TableRowDetail extends React.PureComponent {

TableRowDetail.propTypes = {
template: PropTypes.func,
detailToggleTemplate: PropTypes.func.isRequired,
detailToggleCellTemplate: PropTypes.func.isRequired,
detailCellTemplate: PropTypes.func.isRequired,
detailToggleCellWidth: PropTypes.number.isRequired,
rowHeight: PropTypes.oneOfType([
Expand Down

0 comments on commit bd49b0e

Please sign in to comment.