fix(react-grid): use a column filter operation as a filter selector value #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const getSelectedFilterOperation = ( | ||
| filterOperations, columnName, filter, columnFilterOperations, | ||
| ) => { | ||
| if (filterOperations[columnName]) { |
There was a problem hiding this comment.
Can we extract getSelectedFilterOperation function to helpers file?
There was a problem hiding this comment.
It's quite specific and used only here. I'm not sure it's necessary.
There was a problem hiding this comment.
But in all packages, we extract specific methods to clear plugins code. If we want to support other frameworks we should extract all functionality to common package
MaximKudriavtsev
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1474