feat(react-grid): provide a way to customize a summary item #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushkal
changed the title
|
Use the |
ushkal
changed the title
| <TableSummaryItem className="custom-class" /> | ||
| <TableSummaryItem | ||
| {...defaultProps} | ||
| className="custom-class" |
There was a problem hiding this comment.
I think, in this test we should check both classes: dx-g-bs4-table-summary-item and custom-class. Also, we can rename it to should pass the className prop to the root element.
| @@ -17,6 +23,7 @@ describe('TableSummaryItem', () => { | |||
| it('should pass style to the root element', () => { | |||
There was a problem hiding this comment.
There isn't any code that merges styles for a summary item. Well, we can have a more common test here. Something like should pass rest props to the root element.
ushkal
force-pushed
the
summary-customization
branch
from
766ac76
to
b59366c
Compare
SergeyAlexeev
approved these changes
Nov 7, 2018
viterobk
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1525