New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(chart-core): migrate chart core to TS #1816

Merged

Krijovnick merged 23 commits into DevExpress:master from Krijovnick:type_script

Feb 7, 2019

Contributor

Krijovnick commented Jan 31, 2019

No description provided.

Krijovnick added 6 commits

January 25, 2019 15:59


          move to ts

fc6a9b1


          fix tests

d9ac109


          move to ts


          fix some

2028f74


          Merge branch 'master' into type_script

79181b5

# Conflicts:
#	packages/dx-chart-core/src/utils/event-tracker.test.ts
#	packages/dx-chart-core/src/utils/event-tracker.ts
#	packages/dx-core/src/types.ts


          fix test

b21eb0e

Krijovnick requested review from DmitryBogomolov and ushkal

January 31, 2019 17:25

Krijovnick changed the title ~~Type script~~ refactor(chart-core): migrate chart core to TS

Krijovnick changed the title ~~refactor(chart-core): migrate chart core to TS~~ [WIP]refactor(chart-core): migrate chart core to TS

ushkal reviewed

View reviewed changes

packages/dx-chart-core/package.json Outdated Show resolved Hide resolved

ushkal reviewed

View reviewed changes

packages/dx-chart-core/src/plugins/scale/computeds.ts Outdated Show resolved Hide resolved

ushkal reviewed

View reviewed changes

packages/dx-chart-core/src/plugins/scale/computeds.ts Outdated Show resolved Hide resolved

ushkal reviewed

View reviewed changes

packages/dx-chart-core/src/utils/scale.ts Outdated Show resolved Hide resolved

ushkal reviewed

View reviewed changes

packages/dx-chart-core/src/types/utils.types.ts Outdated Show resolved Hide resolved

Krijovnick added 2 commits

February 1, 2019 21:38


          fix after review

f0fa2b4


          fix types for d3

64339b6

Krijovnick force-pushed the type_script branch from 3b37ad5 to 64339b6 Compare

February 2, 2019 13:55

Krijovnick changed the title ~~[WIP]refactor(chart-core): migrate chart core to TS~~ refactor(chart-core): migrate chart core to TS

Krijovnick and others added 9 commits

February 2, 2019 17:25


          fix tests

a488494


          Merge branch 'master' into type_script

c95625e


          Add some specific types, declare some function arguments in-place

bf0c513


          Update some types in series, scale, stack

865a5c1


          Update some types in animation, tooltip

59a7568


          Remove some files

308b31d


          Add 'readonly' to some fields

c61e525


          Use more specific types and remove 'as' casting where available

affd829


          Use 'PureComputed' in functions used in Getters

4b128b3

DmitryBogomolov force-pushed the type_script branch from 02ca613 to 4b128b3 Compare

February 5, 2019 16:14

ushkal reviewed

View reviewed changes

packages/dx-chart-core/src/plugins/axis/computeds.ts Outdated Show resolved Hide resolved


          remove unnecessary readonly

af27501

DmitryBogomolov approved these changes

View reviewed changes

ushkal reviewed

View reviewed changes

packages/dx-chart-core/src/plugins/axis/computeds.ts Outdated Show resolved Hide resolved

ushkal approved these changes

View reviewed changes

Krijovnick and others added 5 commits

February 7, 2019 11:53


          Merge branch 'master' into type_script

8cd7959

# Conflicts:
#	packages/dx-chart-core/package.json
#	yarn.lock


          update packge.json after merge

fdeaf8d


          Merge branch 'master' into type_script

99cc5bc


          create types.ts files

41c4514


          Merge branch 'master' into type_script

0253fbd

Krijovnick merged commit 23a17e8 into DevExpress:master

Krijovnick deleted the type_script branch

February 7, 2019 14:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment