refactor(react-grid): migrate to TS #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushkal
commented
Feb 11, 2019
| @@ -49,7 +49,7 @@ Describes the grouping panel item properties. | |||
| Field | Type | Description | |||
| ------|------|------------ | |||
| column | [Column](grid.md#column) | A column associated with the item. | |||
| draft? | string | The item preview mode. Contains the "add", "remove" or "reorder" value. | |||
| draft? | boolean | Specifies if the item is in preview mode. | |||
There was a problem hiding this comment.
Note: GroupPanelItem requires boolean - https://github.com/DevExpress/devextreme-reactive/blob/master/packages/dx-react-grid/src/components/group-panel-layout/item-layout.jsx#L49
ushkal
changed the title
packages/dx-react-grid/src/types/column-operations/column-chooser.types.ts
Outdated
Show resolved
Hide resolved
DmitryBogomolov
approved these changes
Feb 13, 2019
packages/dx-react-grid/src/types/column-operations/drag-drop-provider.types.ts
Outdated
Show resolved
Hide resolved
SergeyAlexeev
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.