feat(react-scheduler): add editing by dragging #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitryBogomolov
approved these changes
Mar 12, 2019
Krijovnick
approved these changes
Mar 12, 2019
packages/dx-react-scheduler-demos/src/demo-sources/scheduler-editing/material-ui/drag-drop.jsx
Outdated
Show resolved
Hide resolved
packages/dx-react-scheduler-material-ui/src/templates/all-day-panel/container.jsx
Outdated
Show resolved
Hide resolved
packages/dx-react-scheduler-material-ui/src/templates/drag-drop/appointments.jsx
Outdated
Show resolved
Hide resolved
packages/dx-react-scheduler-material-ui/src/templates/drag-drop/container.jsx
Outdated
Show resolved
Hide resolved
| {payload && params.data.id === payload.id ? ( | ||
| <SourceAppointment {...params} /> | ||
| ) : ( | ||
| <TemplatePlaceholder params={{ ...params, style: { ...params.style, cursor: 'pointer' } }} /> |
There was a problem hiding this comment.
Can we get rid of cursor: 'pointer' in core plugin?
There was a problem hiding this comment.
We can pass a draggingEnabled property to Appointment Component and use it.
There was a problem hiding this comment.
I think it's the closest way to 'ideology'))
There was a problem hiding this comment.
I have passed a clickable property into an appointment component
There was a problem hiding this comment.
The component doesn't know about dragging, it know only about itself is clickable.
SergeyAlexeev
approved these changes
Mar 13, 2019
ushkal
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.