perf(react-grid): avoid unnecessary row rerendering #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyAlexeev
changed the title
ushkal
reviewed
Apr 16, 2019
packages/dx-react-grid/src/components/table-layout/virtual-row-layout.test.tsx
Show resolved
Hide resolved
ushkal
reviewed
Apr 16, 2019
packages/dx-react-grid/src/components/table-layout/virtual-row-layout.test.tsx
Outdated
Show resolved
Hide resolved
ushkal
reviewed
Apr 16, 2019
packages/dx-react-grid/src/components/table-layout/virtual-row-layout.tsx
Outdated
Show resolved
Hide resolved
ushkal
reviewed
Apr 16, 2019
packages/dx-react-grid/src/components/table-layout/virtual-row-layout.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| const propsAreEqual = argumentsShallowEqual(nextColumns, prevColumns) | ||
| && argumentsShallowEqual(nextColSpans, prevColSpans) | ||
| && prevRow === nextRow; |
There was a problem hiding this comment.
Since it is all about performance the prevRow === nextRow check should be moved to the beginning of the method.
Array lengths compare should be moved as well.
if (prevRow !== nextRow || prevCells.length !== nextCells.length) {
return true;
}It would allow to avoid unnecessary arrays creation and comparing.
| shouldComponentUpdate(nextProps) { | ||
| const { cells: prevCells, row: prevRow } = this.props; | ||
| const { cells: nextCells, row: nextRow } = nextProps; | ||
| const [nextColumns, nextColSpans] = nextCells.reduce(reducer, [[], []]); |
There was a problem hiding this comment.
How about avoiding creation of two auxiliary arrays?
const areNotEqual = nextCells.some((nextCell, i) => {
const prevCell = prevCells[i];
return prevCell.column !== nextCell.column || prevCell.colSpan !== nextCell.colSpan;
});
ushkal
approved these changes
Apr 18, 2019
DmitryBogomolov
approved these changes
Apr 18, 2019
ushkal
pushed a commit
to ushkal/devextreme-reactive
that referenced
this pull request
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1925