Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-grid): change processing of last page in lazy load mode #2067

Merged
merged 2 commits into from Jun 6, 2019
Merged

fix(react-grid): change processing of last page in lazy load mode #2067

merged 2 commits into from Jun 6, 2019

Conversation

ushkal
Copy link
Contributor

@ushkal ushkal commented Jun 5, 2019

fixes #2062

ushkal
ushkal commented Jun 5, 2019
View reviewed changes
packages/dx-grid-core/src/plugins/virtual-table-state/helpers.ts

const useFirstHalf = referenceIndex % pageSize < pageSize / 2;
const isLastPage = intervalUtil.getLength(newRange) / pageSize < 3;
const start = useFirstHalf || isLastPage
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only this condition was changed

@ushkal ushkal merged commit 2b52fe0 into DevExpress:master Jun 6, 2019
@ushkal ushkal deleted the rvs-sort-no-load branch June 6, 2019 11:27
@yedukondalurd
Copy link

When can we have these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitryBogomolov DmitryBogomolov DmitryBogomolov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VirtualTable rows sometimes do not render on last page in lazy load mode
3 participants
@ushkal @yedukondalurd @DmitryBogomolov