feat(react-grid): implement column chooser #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvet
reviewed
Sep 27, 2017
| columns | Array<[Column](grid.md#column)> | | Specifies for which row object fields columns are created. | ||
| hiddenColumns | Array<string> | [] | An array containing the names of the columns to be hidden. | ||
| onHiddenColumnsChange | (nextHiddenColumns: Array<string>) => void | | Handles column visibility change. | ||
| contentTemplate | (args: [ColumnChooserRootArgs](#column-chooser-root-args)) => ReactElement | | A template that renders the column chooser markup. |
There was a problem hiding this comment.
contentTemplate with ColumnChooserRootArgs... It's quite strange
There was a problem hiding this comment.
Also seems that we should extract container and item templates for API consistency
kvet
reviewed
Sep 27, 2017
| @@ -0,0 +1,30 @@ | |||
| # HiddenTableColumns Plugin Reference | |||
kvet
reviewed
Sep 27, 2017
dxbykov
reviewed
Sep 28, 2017
| @@ -0,0 +1,38 @@ | |||
| # Grid Reference | |||
| Field | Type | Description | ||
| ------|------|------------ | ||
| columnChooserItems | Array<[ColumnChooserItem](#column-chooser-item)> | An array of column chooser items. | ||
| onColumnToggle | (columnName: string) => void | Handles column visibility change. |
There was a problem hiding this comment.
Discussed this with our technical writer. The onColumnToggle is correct.
dxbykov
approved these changes
Sep 28, 2017
SergeyAlexeev
approved these changes
Sep 28, 2017
gsobolev
force-pushed
the
column-chooser
branch
from
d8bb399
to
f5b38f0
Compare
kvet
approved these changes
Oct 4, 2017
viterobk
approved these changes
Oct 4, 2017
| }; | ||
| ``` | ||
|
|
||
| At this point, the Grid and the ColumnChooser a synchronized. |
There was a problem hiding this comment.
"At this point, the Grid and the ColumnChooser a synchronized."?
dirk-pieterse
approved these changes
Oct 6, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.