New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(react-grid-material-ui): get rid of the Paper wrapper #487
refactor(react-grid-material-ui): get rid of the Paper wrapper #487
Conversation
<DemoContainer> | ||
<Component /> | ||
</DemoContainer> | ||
); | ||
if (currentTheme === 'material-ui') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you write it here? There is DemoContainer for that purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, I wrap all elements in a demo with Paper. It makes sense for the Theming and Column Chooser ones. It looks like, I should wrap only Grid...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the following demos:
- featured-redux-integration (nested grid)
- featured-controlled-mode (grid in delete confirmation)
BREAKING CHANGE:
To make Grid for Material UI more flexible we've stopped using the Paper component inside the Grid's layout.
It allows placing our Grid to an existing Paper with other components. For example: