Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(react-grid-material-ui): get rid of the Paper wrapper #487

Merged
merged 6 commits into from Nov 18, 2017

Conversation

SergeyAlexeev
Copy link
Contributor

@SergeyAlexeev SergeyAlexeev commented Nov 16, 2017

BREAKING CHANGE:
 
To make Grid for Material UI more flexible we've stopped using the Paper component inside the Grid's layout.
 
It allows placing our Grid to an existing Paper with other components. For example:

<Paper>
  <Button>Products</Button>
  <Button>Customers</Button>
  <Button>Sales</Button>
  <Grid
    /* ... */
  >
    {/* ... */}
  </Grid>
</Paper>

<DemoContainer>
<Component />
</DemoContainer>
);
if (currentTheme === 'material-ui') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you write it here? There is DemoContainer for that purposes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, I wrap all elements in a demo with Paper. It makes sense for the Theming and Column Chooser ones. It looks like, I should wrap only Grid...

Copy link
Contributor

@kvet kvet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the following demos:

  • featured-redux-integration (nested grid)
  • featured-controlled-mode (grid in delete confirmation)

@SergeyAlexeev SergeyAlexeev merged commit 2e40de9 into DevExpress:master Nov 18, 2017
@SergeyAlexeev SergeyAlexeev deleted the remove-mui-paper branch November 18, 2017 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants